[winswitch] xpra 0.6.1 -- feedback

[Dmitry Smirnov]

Hi Antoine,

Thank you for your work. I hope you don't mind some feedback:

First of all I think changing default encoding from PNG wasn't such a good 
idea. By default visual quality is now degraded comparing to previous 
versions. (I know I can override in config but I would prefer high quality 
defaults). Personally I feel very uncomfortable with new defaults.

Of course first thing I tried is to change encoding as soon as I connected to 
0.6.1 instance using 0.6.1 as client. When I've chosen "vpx" as compression, 
xpra (client) crashed as soon as I moved mouse over remote application.
The following was printed to console:

Exception in thread Thread-1:
Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 551, in __bootstrap_inner
    self.run()
  File "/usr/lib/python2.7/threading.py", line 504, in run
    self.__target(*self.__args, **self.__kwargs)
  File "/usr/lib/python2.7/dist-packages/xpra/proxy.py", line 26, in 
_to_client_loop
    self._copy_loop("<-server", self._server_conn, self._client_conn)
  File "/usr/lib/python2.7/dist-packages/xpra/proxy.py", line 36, in 
_copy_loop
    buf = untilConcludes(from_conn.read, 4096)
  File "/usr/lib/python2.7/dist-packages/xpra/bytestreams.py", line 16, in 
untilConcludes
    return f(*a, **kw)
  File "/usr/lib/python2.7/dist-packages/xpra/bytestreams.py", line 66, in 
read
    return self._s.recv(n)
error: [Errno 104] Connection reset by peer

Exception in thread Thread-2:
Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 551, in __bootstrap_inner
    self.run()
  File "/usr/lib/python2.7/threading.py", line 504, in run
    self.__target(*self.__args, **self.__kwargs)
  File "/usr/lib/python2.7/dist-packages/xpra/proxy.py", line 30, in 
_to_server_loop
    self._copy_loop("->server", self._client_conn, self._server_conn)
  File "/usr/lib/python2.7/dist-packages/xpra/proxy.py", line 43, in 
_copy_loop
    written = untilConcludes(to_conn.write, buf)
  File "/usr/lib/python2.7/dist-packages/xpra/bytestreams.py", line 16, in 
untilConcludes
    return f(*a, **kw)
  File "/usr/lib/python2.7/dist-packages/xpra/bytestreams.py", line 69, in 
write
    return self._s.send(buf)
error: [Errno 32] Broken pipe

2012-09-15 11:26:24,544 Connection lost

Reconnecting to server wasn't possible. Server log had only one error:

	[swscaler @ 0x3eca5e0] 1x1 -> 1x1 is invalid scaling dimension

To fix I ran "xpra upgrade :N" on server and I was able to attach again.

All the best,
Dmitry.