[winswitch] xpra-3.0.5 header file issue

[Antoine Martin]

Please always keep the list CCed.

On 22/01/2020 09:31, Mark Couteau wrote:
> Hi Antoine,
> 
> The Linux Mint distro version of xpra is this:
> xpra/bionic,now 2.1.3+dfsg-1ubuntu1 amd64 [installed]
That's dangerously out of date.

> so, that one is much older than the 3.0.5 version.  I was unsure being
> new to the software if the html version was the way to go.
It really depends on your use-case.
The html5 client is unlikely to ever reach the same level of performance
as the regular client, but on the other hand it doesn't require any
packages to be installed apart from a browser.

> I have used
> vnc and rdp before, but not xpra.  From the tar files out there, html is
> getting the latest efforts.  I will try it soon.
IIRC, there were many improvements to the html5 client during the 2.4.x
and 2.5.x release cycles, not so much in v3.

Cheers
Antoine


> 
> Thanks
> 
> for the support & guidance
> 
> Mark
> 
> On 1/20/20 11:55 PM, Antoine Martin via shifter-users wrote:
>> On 21/01/2020 07:55, Mark Couteau via shifter-users wrote:
>>> Hi List,
>>>
>>> I was working to get xpra-3.0.5 to compile on Linux Mint.
>> This must be an old version.
>>
>>> I got this error from running setup.py
>>>
>>> /usr/include/gtk-2.0/gtk/gtkitemfactory.h:47:1: error: function
>>> declaration isn’t a prototype [-Werror=strict-prototypes]
>>>   typedef void (*GtkItemFactoryCallback)  ();
>>>
>>>                 ^~~~~~~
>>>
>>> I commented out the GtkItemFactoryCallback definition in the header file
>>> and changed the reference to it to the
>>> GtkItemFactoryCallback1 definition.  The program did compile and works
>>> so far.
>> You can undo those changes. You should not be messing with system
>> headers to build things.
>>
>>> I don't know if this is a real issue or something that only caught me
>>> up.  I had this same issue on both Intel and AMD machines.
>> The setup.py file already knows about this issue and will de-activate
>> the warning that causes the build to fail when it detects an Ubuntu
>> distribution that ships with this problematic header file.
>> But your Linux Mint distribution string is not known about, so this
>> doesn't happen automatically. Instead, you can run the build with:
>> python setup.py --without-strict
>> Which will turn off all the warnings (and not just this one) and allow
>> the build to proceed.
>>
>> Cheers,
>> Antoine
>>
>>> Thanks
>>>
>>>
>>> _______________________________________________
>>> shifter-users mailing list
>>> shifter-users at lists.devloop.org.uk
>>> https://lists.devloop.org.uk/mailman/listinfo/shifter-users
>> _______________________________________________
>> shifter-users mailing list
>> shifter-users at lists.devloop.org.uk
>> https://lists.devloop.org.uk/mailman/listinfo/shifter-users